-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudax fixes for msvc 14.41 #3200
base: main
Are you sure you want to change the base?
Conversation
@@ -140,6 +140,7 @@ class extents | |||
// internal typedefs which for technical reasons are public | |||
using __storage_t = | |||
__detail::__partially_static_sizes_tagged<__detail::__extents_tag, index_type, size_t, _Extents...>; | |||
using __indices_t = _CUDA_VSTD::integer_sequence<size_t, _Extents...>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this a template and then have __indices_t<_Extents...>{}
and __indices_t<_OtherExtents...>{}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the point of this change is because msvc gets confused by the pack expansion at the point of use.
/ok to test |
🟩 CI finished in 2h 07m: Pass: 100%/170 | Total: 2d 22h | Avg: 24m 44s | Max: 1h 12m | Hits: 91%/22510
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 170)
# | Runner |
---|---|
125 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
Description
I needed these changes to build cudax with VC++ 2022 (v14.41) which we currently do not test in CI.
Checklist