Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/week xml 07 #14

Open
wants to merge 17 commits into
base: develop-xml
Choose a base branch
from
Open

Feat/week xml 07 #14

wants to merge 17 commits into from

Conversation

hyoeunjoo
Copy link
Collaborator

@hyoeunjoo hyoeunjoo commented May 31, 2024 •
edited
Loading

πŸ“Œπ˜π˜΄π˜΄π˜Άπ˜¦π˜΄

πŸ“Žπ˜žπ˜°π˜³π˜¬ π˜‹π˜¦π˜΄π˜€π˜³π˜ͺ𝘱𝘡π˜ͺ𝘰𝘯

  • Repositoryλ₯Ό μ΄μš©ν•΄μ„œ UI와 Data둜직 λΆ„λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
  • week 06μ—μ„œ κ΅¬ν˜„ν–ˆμ–΄μ„œ 달라진 뢀뢄은 많이 μ—†μŠ΅λ‹ˆλ‹€.

πŸ“·π˜šπ˜€π˜³π˜¦π˜¦π˜―π˜΄π˜©π˜°π˜΅

화면은 이전과 λ™μΌν•˜κ²Œ μž‘λ™λ©λ‹ˆλ‹€.

πŸ’¬π˜›π˜° π˜™π˜¦π˜·π˜ͺ𝘦𝘸𝘦𝘳𝘴

6μ£Όμ°¨ 코리λ₯Ό μ œλŒ€λ‘œ λ°˜μ˜ν•˜μ§€ λͺ»ν–ˆμŠ΅λ‹ˆλ‹€..! μ‹œν—˜ λλ‚˜κ³  μ–Όλ₯Έ λ°˜μ˜ν•˜κ² μŠ΅λ‹ˆλ‹€
λΆ€μ‘±ν•œ 뢀뢄듀은 μ–Έμ œλ“ μ§€ λ§μ”€ν•΄μ£Όμ„Έμš”!

hyoeunjoo and others added 17 commits May 24, 2024 21:59
@hyoeunjoo
[Del] : 파일 μ‚­μ œ
975a331
@hyoeunjoo
[feat] : 데이터 ꡬ쑰 λ³€κ²½
505b669
@hyoeunjoo
[mod] : Friend 데이터 ꡬ쑰 λ³€κ²½
edb7692
@hyoeunjoo
[mod] : HomeFragment ꡬ쑰 λ³€κ²½
45e1a01
@hyoeunjoo
[mod] : Login ViewModel 뢄리
afc9148
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
d6c1422
@hyoeunjoo
[MOD] : Dto ꡬ쑰 λ³€κ²½
f996c6e
@hyoeunjoo
[MOD] : 파일 ꡬ쑰 λ³€κ²½
804bf83
@hyoeunjoo
[MOD] : mbtiλ₯Ό phone으둜 λ³€κ²½
d17144f
@hyoeunjoo
[FEAT] : SignUp ViewModel 뢄리
7449c36
@hyoeunjoo
[FEAT] : USER 데이터 ꡬ쑰 λ³€κ²½
cf5d656
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
b1fd230
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
d5b0160
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
9caf82f
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
276c39b
@hyoeunjoo
[Mod] : MutableLiveData둜 λ³€κ²½
d67b3cd
@hyoeunjoo
[CHORE] : μ½”λ“œ 정리
4c89de2
@hyoeunjoo hyoeunjoo self-assigned this May 31, 2024
OliviaYJH
OliviaYJH approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@OliviaYJH OliviaYJH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΄λ‹€!!

app/src/main/java/com/sopt/now/data/api/AuthService.kt
@GET("member/info")
fun getUserInfo(
@Header("memberId") memberId : Int
): Call<ResponseUserProfile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš”κΈ°λ§Œ λ‹€λ₯Έ μ„œλ²„ 톡신과 응닡 데이터 ν˜•μ‹μ΄ λ‹€λ₯΄λ„€μš”! ν˜Ήμ‹œ μ΄μœ κ°€ μžˆμ„κΉŒμš”?

app/src/main/java/com/sopt/now/presentation/Login/LoginViewModelFactory.kt
import com.sopt.now.data.AuthRepoImpl
import com.sopt.now.data.api.ServicePool

class LoginViewModelFactory : ViewModelProvider.Factory {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ©‹μ Έμš”!!

chanubc
chanubc reviewed Jun 9, 2024
View reviewed changes
Copy link
Member

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 μ €λ²ˆμ£Όμ°¨μ™€ λ™μΌν•΄λ³΄μ—¬μ„œ
μ €λ²ˆμ£Όμ°¨κ°€ λ¨Έμ§€ν•˜κ³  λ‹€μ‹œ λ¦¬λ·°ν•΄λ“œλ¦΄κ²Œμš”!!

ν•œ ν•™κΈ°λ™μ•ˆ 정말 κ³ μƒλ§Žμ•˜μ–΄μš”!
κ³ λ§ˆμ›Œμš”γ… γ… 

app/src/main/java/com/sopt/now/domain/AuthRepository.kt
Comment on lines +6 to +9
interface AuthRepository {
suspend fun logIn(authData: AuthEntity): Result<Response<Unit>>
suspend fun signUp(authData: AuthEntity): Result<Response<Unit>>
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웨케 μž˜ν•΄μš”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanubc chanubc chanubc left review comments

@OliviaYJH OliviaYJH OliviaYJH approved these changes

@cacaocoffee cacaocoffee Awaiting requested review from cacaocoffee

@kez-lab kez-lab Awaiting requested review from kez-lab

At least 2 approving reviews are required to merge this pull request.

Assignees

@hyoeunjoo hyoeunjoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat/week7] : ν•„μˆ˜κ³Όμ œ
3 participants
@hyoeunjoo @OliviaYJH @chanubc