Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrappers initialisation from full list of hyper-params #157

Open
blondered opened this issue Jul 10, 2024 · 0 comments · Fixed by #170
Open

Wrappers initialisation from full list of hyper-params #157

blondered opened this issue Jul 10, 2024 · 0 comments · Fixed by #170
Assignees
Labels
enhancement New feature or request

Comments

@blondered
Copy link
Collaborator

Feature Description

Wrappers initialisation from full list of hyper-params (including wrapped)

Why this feature?

  • It will help us for save/load functions to models.
  • It will help running experiment from configs (not supported in framework but often used by users)
  • It will simplify code for experiments

Additional context

Interface is not decided. Options are:

  1. model_factory method that accepts smth like:
model_type: ials
model_params:
    fit_features_together: True
    implicit_factors: 32
    implicit_alpha: 10
  1. accept params in __init__:
ials = ImplicitALSWrapperModel(fit_features_together=True, wrapped_params = {"factors: 32, alpha: 10"})

wrapped_params and initialised instance of wrapped model are both optional and user needs to pass one of them. If none is passed then default params are used.

@blondered blondered added good first issue Good for newcomers enhancement New feature or request and removed good first issue Good for newcomers labels Jul 10, 2024
@blondered blondered moved this to 🔖 Next in RecTools board Jul 10, 2024
@blondered blondered mentioned this issue Nov 9, 2024
4 tasks
feldlime added a commit that referenced this issue Nov 9, 2024
- Added configs to models

Сloses #108
#157
@blondered blondered assigned blondered and feldlime and unassigned blondered Nov 11, 2024
@blondered blondered moved this from 👀 In review to ✅ Done in RecTools board Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants