-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Declarative Shadow DOM Style Sharing] Multiple style sheets with commas #886
Comments
Seems similar? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#srcset |
Great question.
Update: I was mistaken, a non-URL-encoded comma is valid in a URL.
https://html.spec.whatwg.org/multipage/images.html#srcset-attribute |
Interesting, I'm not a huge fan of that particularly unique constraint on URLs, but aligning with |
Actually, maybe we want to leave this open just as a reminder to update the spec to include this language around the comma? Up to you how to precisely handle this. |
The proposal allows multiple module specifiers in in
adoptedstylesheets
like so:This indicates that comma (or comma-space) is a delimiter between multiple URLs, however commas and spaces are generally allowed in URLs:
This makes a request for
/foo,%20bar,%20baz.css
. How would this proposal disambiguate between anadoptedstylesheets
value with a single URL containing a comma-space or multiple stylesheets?Potentially we could use space as the delimiter and require any spaces in the URL to be encoded as
%20
, though it's weird that this particular attribute would work that way and be different from<link>
. I wish we could just repeat the attribute like<div adoptedstylesheets="/foo.css" adoptedstylesheets="/bar.css"></div>
, but unfortunately the DOM doesn't allow repeated attributes.Is there any precedent in other HTML elements which allow multiple values based on some delimiter? I can't imagine this is the first time it's been wanted.
The text was updated successfully, but these errors were encountered: