Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the constructor of DatastreamMet4FoF and MetrologicalDatastreamMet4FoF #148

Open
BjoernLudwigPTB opened this issue Oct 30, 2020 · 1 comment

Comments

@BjoernLudwigPTB
Copy link
Member

At the moment DatastreamMet4FoF provides a default generator function which is used, when set_generator_function() is called without specifying a function. Since we agreed today, that there actually is no reasonalbe generic signal for a general Datastream, we might as well exchange this default behaviour and specifically ask the user to specify a signal source on initialization with the constructor signature

def __init__(self, data_source: Any = None, generator_function: Callable = None):

and check in the constructor for at least one of these two being specified. Ín the MetrologicalDatastreamMet4FoF we could then either expect the generator_function and data_source to return values and uncertainties or introduce an additional uncertainty_function().

@BjoernLudwigPTB
Copy link
Member Author

We should thoroughly discuss that before we actually implement it, since this means, that a MetrologicalDataStreamAgent can not be added via the GUI to an agent network. Although this might be not really a use case beyond first try outs, when we add the necessity to hand over either a function or a dataset by hand on initialization this will not be possible anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant