Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable API #48

Closed
wants to merge 4 commits into from
Closed

Stable API #48

wants to merge 4 commits into from

Conversation

naveen521kk
Copy link
Member

@naveen521kk naveen521kk commented Mar 28, 2021

I would working over this month on this. For now this is just a draft on how this will look.

Fixes #28
Also, Fixes #37 and Fixes #30

@naveen521kk naveen521kk added help wanted Extra attention is needed Refactor Changes something fully labels Mar 30, 2021
@naveen521kk naveen521kk added this to the v1.0.0 milestone Mar 30, 2021
@naveen521kk naveen521kk force-pushed the stable-api branch 8 times, most recently from e743b68 to 31dec56 Compare May 29, 2021 18:28
@naveen521kk
Copy link
Member Author

For now, an example of using the API would be

>>> from manimpango import *
>>> l = Layout(markup="<span color='BLUE' font_family='Cursive'>Blue</span>")
>>> r = SVGRenderer('blue.svg', 100, 100, l, move_to=(25,25))
>>> r.render()
True

and an SVG file like this would be created.
blue.zip

@PhilippImhof does this look good? Any suggestions?

@naveen521kk
Copy link
Member Author

After implementing Image backend this is done :).

@PhilippImhof
Copy link
Member

This looks very nice at the first glance. As it is a very substantial change (and step forward), I would like to take some time to really look at it in details.

@naveen521kk
Copy link
Member Author

Sure, you could look into this now or later when I complete the image backend. There are many codes that aren't used currently only the image backend will use it.

Change the whole API into something simple
Also use sphinx_rtd_theme
Remove dependency on Manim for tests
Disable tests which are not supported
@naveen521kk
Copy link
Member Author

I think I would something from scratch rather than working on this. So closing.

@naveen521kk naveen521kk closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Refactor Changes something fully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning Code Providing a Stable API Don't depend on Manim for testing
2 participants