Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add vscode entries in Brewfile #1027

Open
ian-h-chamberlain opened this issue Aug 3, 2024 · 0 comments · May be fixed by #1222
Open

Option to add vscode entries in Brewfile #1027

ian-h-chamberlain opened this issue Aug 3, 2024 · 0 comments · May be fixed by #1222

Comments

@ian-h-chamberlain
Copy link
Contributor

As described in the homebrew-bundle README, vscode is a supported option in Brewfiles.

This seems like it would be a convenient addition to the homebrew module - it's already possible to achieve something similar with homebrew.extraConfig but it seems reasonable enough to add this for parity with casks, whalebrew etc.

One question that comes to mind is whether any automatic installation of VSCode should be enabled by such an option, like how whalebrew does:

When this option is used, "whalebrew" is automatically added to homebrew.brews.

Some people might be using programs.vscode or other methods to install VSCode, but in that case they're probably declaring extensions that way, so maybe it would make sense to install the visual-studio-code cask (although some people may want visual-studio-code@insiders instead).
I'd probably lean towards just documenting that VSCode must be installed somehow, since activation would probably just fail anyway if it wasn't: https://github.com/Homebrew/homebrew-bundle/blob/e97d33cc31c64fdd0c7412c182668783a2d706d6/lib/bundle/vscode_extension_installer.rb#L22

Would a PR to add this functionality be accepted? I have a working implementation already so I'm happy to upstream if so.

@fcjr fcjr linked a pull request Dec 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant