Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPT import now includes query parameters in paths for tests with variants #2976

Open
squeek502 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2977
Open

WPT import now includes query parameters in paths for tests with variants #2976

squeek502 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2977

Comments

@squeek502
Copy link
Contributor

After #2848 (cc @tcl3), tests with variants like html/syntax/parsing/html5lib_tests2.html will be listed by list-tests with the paths:

/html/syntax/parsing/html5lib_tests2.html?run_type=uri
/html/syntax/parsing/html5lib_tests2.html?run_type=write
/html/syntax/parsing/html5lib_tests2.html?run_type=write_single

Because list-tests is now used before calling import-wpt-test.py, this means that the ?run_type=uri gets passed along to that script as well, so the files created are:

Tests/LibWeb/Text/input/wpt-import/html/syntax/parsing/html5lib_tests2.html?run_type=uri
Tests/LibWeb/Text/input/wpt-import/html/syntax/parsing/html5lib_tests2.html?run_type=write
Tests/LibWeb/Text/input/wpt-import/html/syntax/parsing/html5lib_tests2.html?run_type=write_single

(the ?run_type=uri, etc are part of the filenames)

The import then fails when trying to run the tests:

Importing test from /html/syntax/parsing/html5lib_tests2.html?run_type=uri
 114633 Lost connection to RequestServer
Runtime error: No tests found matching filter
Importing test from /html/syntax/parsing/html5lib_tests2.html?run_type=write
 114783 Lost connection to RequestServer
Runtime error: No tests found matching filter
Importing test from /html/syntax/parsing/html5lib_tests2.html?run_type=write_single
 114868 Lost connection to RequestServer
Runtime error: No tests found matching filter

I believe query parameters should be stripped before passing the path to import-wpt-test.py, or something to that effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Meta: Strip query string from WPT test variants before importing them tcl3/ladybird
1 participant
@squeek502