Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/webappapis/dynamic-markup-insertion tests are imported incorrectly #2690

Open
shlyakpavel opened this issue Dec 1, 2024 · 0 comments
Open

Comments

@shlyakpavel
Copy link
Contributor

These tests fail as they require JS files that were not imported by WPT importer

./Meta/ladybird.sh run headless-browser --run-tests ./Tests/LibWeb -j1 -f html/webappapis/dynamic-markup-insertion                                   INT ✘  1m 52s
ninja: Entering directory `/Users/pavel/Develop/ladybird/Build/release'
[0/2] Re-checking globbed directories...
ninja: no work to do.
Fontconfig error: Cannot load default config file: No such file: (null)
Running 70 tests...
11/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_011.html768699.959 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/011.js", Error: No such file or directory (errno=2), Duration: 1ms
768699.959 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
12/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_010.html768699.986 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/010.js", Error: No such file or directory (errno=2), Duration: 1ms
768699.987 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/010-1.js", Error: No such file or directory (errno=2), Duration: 1ms
768699.987 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
13/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_006.html768700.004 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/006.js", Error: No such file or directory (errno=2), Duration: 1ms
768700.004 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
46/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.html768700.729 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.js", Error: No such file or directory (errno=2), Duration: 1ms
768700.730 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
59/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_005.html768701.036 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/005.js", Error: No such file or directory (errno=2), Duration: 1ms
768701.036 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
64/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_012.html768701.162 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/012.js", Error: No such file or directory (errno=2), Duration: 1ms
768701.162 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
67/70: Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/script_008.html768701.232 WebContent(36818): ResourceLoader: Failed load of: "file:///Users/pavel/Develop/ladybird/Tests/LibWeb/Text/input/wpt-import/html/webappapis/dynamic-markup-insertion/document-write/008-1.js", Error: No such file or directory (errno=2), Duration: 1ms
768701.232 WebContent(36818): HTMLScriptElement: Refusing to run script because the element's result is null.
Done!
==========================================================
Pass: 70, Fail: 0, Skipped: 0, Timeout: 0, Crashed: 0
==========================================================

I could just manually add missing scripts to the repo and rebaseline the tests, or we could work in improving the importer and reimport these..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant