Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable shutdown code #76

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Remove unreachable shutdown code #76

merged 1 commit into from
Sep 30, 2020

Conversation

featherbear
Copy link
Contributor

@featherbear featherbear commented Sep 30, 2020 •
edited
Loading

  • Implementing __del__ is discouraged
    • Imports (i.e. import logging) are cleaned up, leading to NoneType related errors
  • When running via GUI mode, the shutdown code is never reached; we can let Python's internal GC clean everything

Fixes #70

@featherbear
Remove unreachable shutdown code
8af532f 
* Implementing `__del__` is discouraged
  * Imports (i.e. `import logging`) are cleaned up, leading to NoneType related errors
* When running via GUI mode, the shutdown code is never reached; we can let Python's internal GC clean everything
@Kilian Kilian merged commit f37c8b6 into Kilian:master Sep 30, 2020
@Kilian
Copy link
Owner

Kilian commented Sep 30, 2020

thanks!

@diklimchuk diklimchuk mentioned this pull request Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli works but crashes at the end
2 participants
@featherbear @Kilian