Fix Windows DLL test configuration #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-lunarg
force-pushed
the
hayes-fix-windows-dll-ci
branch
from
7d0aab0 to
6d499a8
Compare
dneto0
suggested changes
Dec 12, 2024
| @@ -39,7 +39,7 @@ set -e # Fail on any error. | |||
|
|
|||
| set -x # Display commands being run. | |||
|
|
|||
| using cmake-3.17.2 | |||
| using cmake-3.27 | |||
There was a problem hiding this comment.
This needs to correspond to a cmake that has been put into the kokoro image.
It should be cmake-3.31.2
jeremy-lunarg
force-pushed
the
hayes-fix-windows-dll-ci
branch
from
6d499a8 to
cee57f8
Compare
jeremy-lunarg
force-pushed
the
hayes-fix-windows-dll-ci
branch
from
cee57f8 to
8c87d49
Compare
Enable Windows DLL test configuration. Configure tests to pull in DLL dependencies using TARGET_RUNTIME_DLL_DIRS. Bump cmake version to 3.27 to use TARGET_RUNTIME_DLL_DIRS. Remove Ubuntu 20.04 test configuration.
jeremy-lunarg
force-pushed
the
hayes-fix-windows-dll-ci
branch
from
8c87d49 to
90e1405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Windows DLL test configuration.
Configure tests to pull in DLL dependencies using
TARGET_RUNTIME_DLL_DIRS.Bump cmake version to 3.27 to use
TARGET_RUNTIME_DLL_DIRS.Remove Ubuntu 20.04 test configuration.