Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Settings need a way to validate VkLayerSettingEXT #254

Open
spencer-lunarg opened this issue Dec 16, 2024 · 1 comment
Open

Layer Settings need a way to validate VkLayerSettingEXT #254

spencer-lunarg opened this issue Dec 16, 2024 · 1 comment

Comments

@spencer-lunarg
Copy link
Contributor

Brought up in KhronosGroup/Vulkan-ValidationLayers#9028

I have no good way in the Validation Layers (without me, and every other layer having to hand-write it) to make sure the VkLayerSettingEXT passed in from the app

  1. Is not using a pSettingName that doesn't exists (aka, a setting was removed and they are still setting it)
  2. Validate the type is correct (you try setting INT32 of 1 or FLOAT32 of 1.0 instead of using a BOOL32
@spencer-lunarg
Copy link
Contributor Author

Another issue I realized is in the JSON we just list things are INT for vkconfig, but have no way to know if that means the setting is actually VK_LAYER_SETTING_TYPE_INT32_EXT or VK_LAYER_SETTING_TYPE_UINT32_EXT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant