Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic types referencing @mui/x-date-pickers wrong after v2.13.0 #1320

Open
1 task done
lpicchi opened this issue Dec 3, 2024 · 0 comments
Open
1 task done

Generic types referencing @mui/x-date-pickers wrong after v2.13.0 #1320

lpicchi opened this issue Dec 3, 2024 · 0 comments

Comments

@lpicchi
Copy link

lpicchi commented Dec 3, 2024

material-react-table version

v2.13.0

react & react-dom versions

v18.3.1

Describe the bug and the steps to reproduce it

When using version > v2.13.0 some types definitions referencing @mui/x-date-pickers are wrongly using generics

Example:

  • Before v2.13.0 (Correct use of generics):

image

  • After v2.13.0 (Incorrect use of generics):

image
image

Looking at src/types.ts for v2 it looks fine. But the types generated in dist when building seems to be different and wrong

For v2.13.0 there are six places where types are wrong

image

But for v2.13.1 only 3 places

image

So it seems part of the issue has been solved between v2.13.0 and v2.13.1 somehow

I'm not able to use tools like dts-bundle-generator because of this problem and had to downgrade to 2.12.1

Minimal, Reproducible Example - (Optional, but Recommended)

Optional

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

Maybe, I'll investigate and start debugging

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant