fix: simplify logic for hiding/showing all columns within show/hide menu #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality to show/hide all columns within the ShowHideColumnsMenu was implemented with a custom function which filters all columns and toggles the visibility of each column. This calls the `onColumnVisibilityChange` callback multiple times. In my opinion this can be refactored to use the tables `toggleAllColumnsVisible` API, which results in only one call of `onColumnVisibilityChange` and makes the code easier to understand. Fixes: KevinVandy#1277
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KevinVandy
reviewed
Dec 22, 2024
| @@ -45,12 +44,6 @@ export const MRT_ShowHideColumnsMenu = <TData extends MRT_RowData>({ | |||
| } = table; | |||
| const { columnOrder, columnPinning, density } = getState(); | |||
|
|
|||
| const handleToggleAllColumns = (value?: boolean) => { | |||
There was a problem hiding this comment.
I remember having good reasons for doing it this way. I think it had to do with hiding and showing grouped columns correctly. Will need to test further. At worst, may have to just use a table.setColumnVisibility(prev => /**/) call with the correct ids
There was a problem hiding this comment.
When hiding all columns within the first grouping example the output is the same as on the official documentation:
But please test further to find some egde cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality to show/hide all columns within the ShowHideColumnsMenu was implemented with a custom function which filters all columns and toggles the visibility of each column. This calls the
onColumnVisibilityChangecallback multiple times.In my opinion this can be refactored to use the tables
toggleAllColumnsVisibleAPI, which results in only one call ofonColumnVisibilityChangeand makes the code easier to understand.Fixes: #1277