Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Pinning columns to the right pushes item to the bottom of menu #1018

Open
1 task done
renatoka opened this issue Feb 29, 2024 · 1 comment · May be fixed by #1019
Open
1 task done

[UX] Pinning columns to the right pushes item to the bottom of menu #1018

renatoka opened this issue Feb 29, 2024 · 1 comment · May be fixed by #1019

Comments

@renatoka
Copy link
Contributor

material-react-table version

v2.12.1

react & react-dom versions

18.2.60 && @18.2.0

Describe the bug and the steps to reproduce it

While pinning columns to the right, pinned column menu item gets pushed to the bottom of the menu, which is kinda unpleasant as it doesn't happen to the column items pinned to the left(they keep their position in menu order).

Screen.Recording.2024-02-29.at.09.45.58.mov

Minimal, Reproducible Example - (Optional, but Recommended)

Try it on any pinning example.

Screenshots or Videos (Optional)

Proposed solution

Screen.Recording.2024-02-29.at.09.46.34.mov

Do you intend to try to help solve this bug with your own PR?

Yes, I am also opening a PR that solves the problem along side this issue

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@renatoka renatoka linked a pull request Feb 29, 2024 that will close this issue
Open
@fredericbahr
Copy link
Contributor

From my perspective, the current implementation in v3 may feel a bit inconvenient for users due to the "jumping" of items. However, the menu now provides a clearer representation of the structure within the table.

I would suggest keeping the current implementation. Could you share your thoughts on this and perhaps close the issue, @renatoka?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: column right pin ruins menu order renatoka/material-react-table
2 participants
@fredericbahr @renatoka