-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip build step for changes in test
#404
Comments
Do any stdlibs still (as of Julia 1.12) go into the default Julia sysimage? If so, then we'd need to run the If the Julia testsuite (the top-level |
Oh, didn't think of that. I guess you are right.
Yes and Yes.
What I am suggesting is that we grab a build artifact from the CI run of the commit on master from which we branched off (if available). That binary should then be the same as if we were to build it again, no? |
Ah, I see. Yeah, that would be quite clever if we could get it to work. |
So we'd basically need to:
|
test
or any stdlib
test
Sounds like this requires some effort (I am not too familiar with step 2) compared to what would be gained, as the number of PRs that only touch |
Ok, maybe that won't work, as the docstrings are typically baked into sysimages too, so we need to always do a full build. |
Yeah, it seems like we'll need to build Julia for docstring changes. For stdlibs, if there are any stdlibs that are still in the default Julia sysimage, then of course we need to build Julia for PRs that modify those stdlibs. But what about the stdlibs that are no longer in the default Julia sysimage? We still need to test that pkgimages (
|
Yes, I think so too. |
Depends at least on #400
To get this working we need to figure out if the merge-base of a PR provides artifacts which we can then download and use for testing steps.
But it might happen that some artifacts are missing, either due to build errors or timeouts. I guess we should then try to rebuild those again.
The text was updated successfully, but these errors were encountered: