Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect info re: anonymous URLs #11046

Open
qqmyers opened this issue Nov 22, 2024 · 2 comments · May be fixed by #11048
Open

Incorrect info re: anonymous URLs #11046

qqmyers opened this issue Nov 22, 2024 · 2 comments · May be fixed by #11048
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect

Comments

@qqmyers
Copy link
Member

qqmyers commented Nov 22, 2024 •
edited
Loading

What steps does it take to reproduce the issue?

dataverse/src/main/java/propertyFiles/Bundle.properties

Line 1737 in b8e4758

dataset.privateurl.anonymous.description.paragraph.two=The dataset's files are not changed and will be accessible if they're not restricted. Users of the Anonymous Preview URL will not be able to see the name of the Dataverse that this dataset is in but will be able to see the name of the repository, which might expose the dataset authors' identities.

implies restricted files are not accessible, which is not true AFIAK (it wasn't prior to #10961, I don't see changes there to download, and I can still download restricted files from an anonymized url after merging develop into QDR's fork). I suggest just deleting " if they're not restricted" but if the intent was to not allow download of restricted files with an anonymized URL - I suspect there are places that will not want that so we might need a feature flag.

Also - minor:

dataverse/src/main/java/propertyFiles/Bundle.properties

Line 1742 in f95c1a0

dataset.privateurl.disablePrivateUrl=Disable Preview URL
and

dataverse/src/main/java/propertyFiles/Bundle.properties

Line 1745 in f95c1a0

dataset.privateurl.disablePrivateUrlConfirm=Yes, Disable Preview URL
don't appear to be used anymore.

  • When does this issue occur?

  • Which page(s) does it occurs on?

  • What happens?

  • To whom does it occur (all users, curators, superusers)?

  • What did you expect to happen?

Which version of Dataverse are you using?
develop

Any related open or closed issues to this bug report?

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

Guessing this is size 0.5 if it is just the text change, maybe 10 if a change to downloads was intended.
@qqmyers qqmyers added the Type: Bug a defect label Nov 22, 2024
@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Nov 22, 2024
@qqmyers qqmyers added Size: 10 A percentage of a sprint. 7 hours. Size: 0.5 A percentage of a sprint. 0.35 hours labels Nov 22, 2024
@jggautier
Copy link
Contributor

jggautier commented Nov 22, 2024 •
edited
Loading

I agree, someone who gets the anonymous preview url will be able to download files, even if those files are restricted. We didn't mean to change this behavior and that text is wrong. I remember you bringing this up when I was working on this a while ago, too, and I think your point was just lost :(

Removing that part of the text sounds good, or maybe editing it to start with "The datasets files are not changed and users of the Anonymous Preview URL will be able to access them. ..."?

@qqmyers
Copy link
Member Author

qqmyers commented Nov 22, 2024

OK - cool - I'll make a quick PR.

qqmyers added a commit to GlobalDataverseCommunityConsortium/dataverse that referenced this issue Nov 22, 2024
@qqmyers
Text changes to address IQSS#11046
4853f41
@qqmyers qqmyers linked a pull request Nov 22, 2024 that will close this issue
Open
@qqmyers qqmyers removed the Size: 10 A percentage of a sprint. 7 hours. label Nov 22, 2024
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this issue Nov 22, 2024
@qqmyers
fixes suggested in IQSS#11046
2cbcf0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IQSS/11046 - Text changes for Anonymized URLs GlobalDataverseCommunityConsortium/dataverse
2 participants
@qqmyers @jggautier