Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings/settings.xml missing, giving an error #1

Open
t-oster opened this issue Jan 31, 2019 · 3 comments
Open

settings/settings.xml missing, giving an error #1

t-oster opened this issue Jan 31, 2019 · 3 comments

Comments

@t-oster
Copy link

t-oster commented Jan 31, 2019

Hi,
your package is missing settings/settings.xml, which causes VisiCut to throw an error when importing the settings via GUI. The settings still work after restarting VisiCut, but it would be better if it worked without an error message.
I see you intentionally removed the settings.xml and mappings folder with .gitignore, however those files should be there in a basic version.
@t-oster t-oster mentioned this issue Jan 31, 2019
Closed
@mgmax
Copy link

mgmax commented Sep 3, 2021

As there was no response, I would remove the "Hackspace manchester" download option from VisiCut for now.

mgmax added a commit to t-oster/VisiCut that referenced this issue Sep 3, 2021
@mgmax
Remove broken pre-defined settings
14be6a0 
- Hackspace manchester, see HACManchester/visicut-settings#1
- Fablab Bremen (URL does not work anymore)
mgmax added a commit to t-oster/VisiCut that referenced this issue Sep 6, 2021
@mgmax
Remove broken pre-defined settings
ffb0f4b 
- Hackspace manchester, see HACManchester/visicut-settings#1
- Fablab Bremen (URL does not work anymore)
- Renaissance Collenge Hong Kong (same problem)
@thinkl33t
Copy link
Member

I have now fixed this and the settings appear to work, please can we re-add the hacman settings @mgmax @t-oster :)

@t-oster
Copy link
Author

t-oster commented Sep 10, 2022

@thinkl33t can you make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkl33t @t-oster @mgmax