Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution Guidelines #7

Open
GregNGM opened this issue Jan 30, 2021 · 1 comment
Open

Contribution Guidelines #7

GregNGM opened this issue Jan 30, 2021 · 1 comment

Comments

@GregNGM
Copy link
Contributor

GregNGM commented Jan 30, 2021

In a conversation today there was discussion over the number of changes that can be in a pull request. I suggest that there be no more than one tool changed in any PR unless it is an administrative thing that can be reviewed by someone unfamiliar with that tool (such as spelling or formatting changes)

This allows changes to be reviewed by people with knowledge of the tool without holding up a larger pull request waiting for multiple reviews.

We should decide if we want this and document our decision.
@GregNGM
Copy link
Contributor Author

GregNGM commented Jan 30, 2021

We should also have a rule regarding the merging of procurement list changes without Board approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GregNGM