[$1000] mWeb Android - Not able to create multiline description

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on + icon and select assign task option
2. Enter title and enter description
3. Click on ↩️ icon of keyboard which is in bottom right corner

Expected Result:

Should add new line same app

Actual Result:

Not able to add new line

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230702_224836_Chrome.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688318894783959

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6d942e70811c529
• Upwork Job ID: 1686831253824323584
• Last Price Increase: 2023-08-11
• Automatic offers:
• chiragxarora | Contributor | 26157668

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[chiragxarora]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb Android - Not able to create multiline description

What is the root cause of that problem?

Root cause is the submitOnEnter prop added recently on the TextInputs for description which are supposedly multiline

This prop causes this behavior as when user presses enter for a new line in description, it rather submits the current form

App/src/pages/tasks/TaskDescriptionPage.js

Lines 67 to 77 in f08ab19

	<TextInput
	inputID="description"
	name="description"
	label={props.translate('newTaskPage.descriptionOptional')}
	defaultValue={(props.task.report && props.task.report.description) || ''}
	ref={(el) => (inputRef.current = el)}
	autoGrowHeight
	submitOnEnter
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	textAlignVertical="top"
	/>

What changes do you think we should make in order to solve the problem?

We need to remove the submitOnEnter prop from here

App/src/pages/tasks/TaskDescriptionPage.js

Line 74 in f08ab19

submitOnEnter

and also other two pages: NewTaskDetailsPage and NewTaskDescriptionPage

As per the new discussion here #21205 (comment) , we are going to keep submitOnEnter and we have decided to opt for an android specific fix.

So since we the issue is only present in mobile web versions, we can disable submitOnEnter on those fields specifically

submitOnEnter={!Browser.isMobile()}

Browser.isMobile() will return true only for mobile web versions where we are unable to enter multiline description

Results

Screenrecorder-2023-07-06-11-38-38-854.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

[chiragxarora]

BUMP @muttmuure

[muttmuure]

Lots of high priorities. Getting to this tomorrow

[muttmuure]

Still not had time

[muttmuure]

Seeing this as fixed

2023-07-17_16-44-25.mp4

Maybe we caught it somewhere else?

[muttmuure]

@aimane-chnaif did we push a fix for android for this?

[chiragxarora]

@muttmuure bug is for the mweb

[aimane-chnaif]

@aimane-chnaif did we push a fix for android for this?

#21664 is for money request description, not task.
That PR is still on hold until all task description issues (like this one) are fixed.

[muttmuure]

I'm also seeing this as fixed on Android Chrome. Am I holding it wrong here?

2023-07-19_13-10-00.mp4

[gadhiyamanan]

@muttmuure still able to reproduce with real device
https://github.com/Expensify/App/assets/54790231/05e35e4c-4c0b-43d5-b131-10b497a29710

[melvin-bot]

@muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

[muttmuure]

Catching up from ooo

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @chiragxarora 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

All yours @chiragxarora !

[chiragxarora]

PR is ready for review @mananjadhav

[mananjadhav]

@chiragxarora I commented on the PR for missing screenshots.

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @chiragxarora, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @chiragxarora got assigned: 2023-08-16 15:19:16 Z
• when the PR got merged: 2023-08-17 17:56:22 UTC

On to the next one 🚀

[mananjadhav]

This was deployed to production 2 days back, but the title wasn't updated.

[mananjadhav]

@muttmuure Can you post the payout summary here? This has been in production for 7 days but the title wasn't updated.

[gadhiyamanan]

@muttmuure i didn't get any upwork offer automatically, can you send offer manually

[mananjadhav]

I would call this as small polish/feature request. We linked the other issue, and the comment says it was expected change. I also don't think we need a regression test here.

[mananjadhav]

@muttmuure quick bump.

[JmillsExpensify]

Waiting on payment summary for NewDot payment.

[muttmuure]

Reporter - @gadhiyamanan $250
C - @chiragxarora $1500
C+ - @mananjadhav $1500

[chiragxarora]

I don't think I received the offer @muttmuure

[muttmuure]

offer sent!

[gadhiyamanan]

@muttmuure i didn't get any offer

[muttmuure]

Sent one to you too @gadhiyamanan

[gadhiyamanan]

@muttmuure offer accepted, thanks!

[muttmuure]

All paid up

[JmillsExpensify]

$1,500 payment approved for @mananjadhav based on BZ summary above.