Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow SP, fates, or nofire tests to turn fire_emis on (and make sure our tests don't do this either) #2762

Open
1 of 4 tasks
ekluzek opened this issue Sep 16, 2024 · 2 comments · May be fixed by #2844
Open
1 of 4 tasks

Don't allow SP, fates, or nofire tests to turn fire_emis on (and make sure our tests don't do this either) #2762

ekluzek opened this issue Sep 16, 2024 · 2 comments · May be fixed by #2844
Assignees
@ekluzek
Labels
bfb bit-for-bit blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options
Milestone
cesm3_0_beta06

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 16, 2024 •
edited
Loading

When -fire_emis is added to CLM_BLDNML_OPTS it should fail for configurations where fire-emissions won't be passed back. Right now that's SP mode, when nofire is turned on for BGC, or for FATES.

The FORTRAN code and build-namelist should disallow these options.

And we should make sure our testing don't turn on fire-emissions for these configurations.

Related issue: #2759

Definition of done:

  • Get the PF unit tests started
  • Update submodules so that full ESMF is available
  • Finish the unit tests with full ESMF
  • Make the needed changes in FORTRAN source and continue to update the unit tests
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability bfb bit-for-bit usability Improve or clarify user-facing options labels Sep 16, 2024
@ekluzek ekluzek self-assigned this Sep 16, 2024
@samsrabin samsrabin added this to the cesm3_0_beta04 milestone Sep 26, 2024
@ekluzek ekluzek added the blocked: dependency Wait to work on this until dependency is resolved label Oct 22, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 22, 2024

In order to get this to work and have it tested in the FORTRAN code, I need to add unit testing around this. I've started doing that, but found out that for example shr_fire_emis_mod.F90 needs the full ESMF library. This is OK, since work was done to bring this into the unit-testing framework for submodules.

As such I need to work on #2640 before getting back to this.

@ekluzek ekluzek linked a pull request Oct 23, 2024 that will close this issue
Draft
@ekluzek ekluzek linked a pull request Nov 5, 2024 that will close this issue
Make sure FORTRAN code properly aborts when fire-emission is asked for and it can't be provided #2844
Draft
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 5, 2024

The first part of this for Sprint 11 was a few days of work. I put it at 0.5 of a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bfb bit-for-bit blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options
Projects
LMWG: Near Term Priorities
Status: Done
Milestone
cesm3_0_beta06
2 participants
@samsrabin @ekluzek