Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logic: Filled icons are the primary ones, not outlined. #42

Open
cyntss opened this issue Jan 27, 2022 · 1 comment
Open

Comments

@cyntss
Copy link
Member

cyntss commented Jan 27, 2022

The issue is the following:

All eos-icons are first created in outlined version. Then, when necessary, an outlined version is created. But, this is not always the case because in certain scenarios it makes no sense to create an outlined icon since the filled version is already a line, for example.

The logic in https://github.com/EOS-uiux-Solutions/eos-icons-api/blob/main/src/utils/tools/getSvgCode.ts was created based on the contrary assumption, that icons were first created outlined. This is why we need to change it.

See the conversation below for more background:

image

@codetheorem
Copy link
Member

@cyntss I want to work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants