Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: always generate a children method on component prop builders #2281

Open
jkelleyrtp opened this issue Apr 9, 2024 · 0 comments · May be fixed by #2832
Open

Tweak: always generate a children method on component prop builders #2281

jkelleyrtp opened this issue Apr 9, 2024 · 0 comments · May be fixed by #2832
Assignees
Labels
breaking This is a breaking change rsx Related to rsx or the dioxus-rsx crate
Milestone

Comments

@jkelleyrtp
Copy link
Member

jkelleyrtp commented Apr 9, 2024

Feature Request

Right now we can't hotreload component bodies going from something to nothing or nothing to something since that's functionally adding/removing a .children() method.

In debug or dev mode we should always pass in children as either some or none into the builder, even if the component doesn't do anything with those children. This would let us hotreload component bodies in more cases than we do today.

This would be breaking (might be able to find a way around it).

@jkelleyrtp jkelleyrtp added this to the 0.6.0: Fullstack milestone Apr 9, 2024
@jkelleyrtp jkelleyrtp added the rsx Related to rsx or the dioxus-rsx crate label Apr 9, 2024
@jkelleyrtp jkelleyrtp added the breaking This is a breaking change label Aug 8, 2024
@DogeDark DogeDark linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change rsx Related to rsx or the dioxus-rsx crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants