Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar updates #4

Open
2 of 5 tasks
QartemisT opened this issue Dec 8, 2020 · 4 comments
Open
2 of 5 tasks

Bar updates #4

QartemisT opened this issue Dec 8, 2020 · 4 comments
Assignees
Labels
🛠 Enhancement New feature or request Low Priority This issue will not be worked on unless there are no high or medium tasks left

Comments

@QartemisT
Copy link
Member

QartemisT commented Dec 8, 2020

Tracking list for bar releated features todo;

@QartemisT QartemisT self-assigned this Dec 8, 2020
@MysticalOS
Copy link
Member

MysticalOS commented Aug 15, 2021

  • New GUI option dropdown that chooses behavior of "keep" bar types.
  1. Option 1: Display amount of time the ability has been off CD as a negative number (current behavior)
  2. Option 2: Pause bar and disable bar animations (such as spark/flashing) when it reaches 0 (0.01 effectively) if it's type is "keep' and hold bar there. This behavior is what BW users are used to

@MysticalOS
Copy link
Member

Expanding on 3rd bar anchor.

  1. By default, plugin bars such as pvp and spelltimers should be assigned to it automatically.
  2. However, the user should be able to also choose to put "Important" (user activated type 7) bars there if they want
  3. Users should be able to also choose (independantly from small bar anchor option) to decide whether bars move from Tools anchor to large anchor.

@MysticalOS MysticalOS transferred this issue from DeadlyBossMods/DeadlyBossMods Sep 18, 2021
@MysticalOS MysticalOS added 🛠 Enhancement New feature or request Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete labels Sep 19, 2021
@MysticalOS MysticalOS added Low Priority This issue will not be worked on unless there are no high or medium tasks left Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete and removed Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete labels Oct 13, 2021
@MysticalOS
Copy link
Member

MysticalOS commented Jan 5, 2022

For ages, The "style" of bar has been DBM (Classic) and Simple (No animation)

But in reality the drop down toggles two behaviors not one, an these need to be split

  • Behavior 1, Animation: The bar either animatinos from small bars to large, or instantly teleports there (No Animation).

  • Behavior 2, Bar Restart: When the bar reaches "enlarge" threshold, it either continues counting down with original sizing, or it restarts from that threshold.

  • The two features being hacked together is not actually ideal for full customizing. It should be Split into two logical options and the "type/style" drop down probably removed

  • Option 1: "Animate bar moving between small and large anchor"

  • Option 2: "Restart bar when it reaches enlarge threshold (if enlarge is disabled, it will restart on the small anchor)"

@MysticalOS MysticalOS added Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete and removed Low Priority This issue will not be worked on unless there are no high or medium tasks left labels Jan 5, 2022
@MysticalOS
Copy link
Member

  • Add option to hide bars over active bars.

This would need to be coded a particular way do to fact we don't want to break bar methods like GetRemaining or GetTime as these would fail if bar doesn't exist, we want hidden bars to exist so it's more likely we'll just set the transparency to fully transparent so they are effectively invisible.

The way I propose is added the code to the Bar sorting method which already has information like number of bars, and after sorting them could simply go "and now bars n+ in table should be fully transparent"

As long as sort function is called on any bar being expired or added (and i think it already is) this would work just fine.

@MysticalOS MysticalOS added Low Priority This issue will not be worked on unless there are no high or medium tasks left and removed Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete labels Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Enhancement New feature or request Low Priority This issue will not be worked on unless there are no high or medium tasks left
Projects
None yet
Development

No branches or pull requests

2 participants