Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition sizing ignores supplementary bundles #5207

Closed
14 tasks
nadove-ucsc opened this issue May 12, 2023 · 1 comment
Closed
14 tasks

Partition sizing ignores supplementary bundles #5207

nadove-ucsc opened this issue May 12, 2023 · 1 comment
Assignees
Labels
+ [priority] High bug [type] A defect preventing use of the system as specified code [subject] Production code demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented May 12, 2023

Subgraph numbers need to be updated for anvildev and anvilprod following the addition of supplementary bundles. This was overlooked during #5059. Additionally, the list_partitions method for the AnVIL plugin doesn't count supplementary bundles. This may be why we didn't see this error on anvildev, because the mistakes cancelled each other out.

[edit: @dsotirho-ucsc]
@hannes-ucsc: "Lets also add a script that facilitates calculating bundle counts that we hard code for each source in AZUL_CATALOGS."

[edit: @hannes-ucsc] To reproduce, one would run IT against a catalog with 1000G in it. See https://gitlab.prod.anvil.gi.ucsc.edu/ucsc/azul/-/jobs/3859 for example.

This gives

======================================================================
FAIL: test_indexing (integration_test.IndexingIntegrationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/ucsc/azul/test/azul_test_case.py", line 208, in wrapped
    return method(*args, **kwargs)
  File "/builds/ucsc/azul/test/integration_test.py", line 442, in test_indexing
    notifications, fqids = self._prepare_notifications(catalog)
  File "/builds/ucsc/azul/test/integration_test.py", line 928, in _prepare_notifications
    list(starmap(update, self._list_bundles(catalog,
  File "/builds/ucsc/azul/test/integration_test.py", line 339, in _list_bundles
    source, prefix, new_fqids = self._list_partition_bundles(catalog, source)
  File "/builds/ucsc/azul/test/integration_test.py", line 312, in _list_partition_bundles
    self.assertLessEqual(bundle_count, upper, partition + ' is too large')
AssertionError: 1484 not less than or equal to 1024 : Partition '1' of source tdr:datarepo-dev-43738c90:snapshot/ANVIL_1000G_2019_Dev_20230302_ANV5_202303032342:/1 is too large

  • Security design review completed; the Resolution of this issue does not
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … introduce a new software dependency like
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below
@nadove-ucsc nadove-ucsc added the orange [process] Done by the Azul team label May 12, 2023
@nadove-ucsc nadove-ucsc changed the title list_partitions ignores supplmentary bundles Partition sizes ignores supplmentary bundles May 12, 2023
@nadove-ucsc nadove-ucsc changed the title Partition sizes ignores supplmentary bundles Partition sizes ignore supplmentary bundles May 12, 2023
@hannes-ucsc hannes-ucsc changed the title Partition sizes ignore supplmentary bundles Partition sizes ignore supplementary bundles May 12, 2023
@hannes-ucsc hannes-ucsc changed the title Partition sizes ignore supplementary bundles Partition sizing ignores supplementary bundles May 12, 2023
@dsotirho-ucsc dsotirho-ucsc added bug [type] A defect preventing use of the system as specified infra [subject] Project infrastructure like CI/CD, build and deployment scripts code [subject] Production code + [priority] High labels May 12, 2023
@hannes-ucsc
Copy link
Member

For demo, show passing IT build in anvilprod on develop branch after PR #5184 lands on develop.

@nadove-ucsc nadove-ucsc added the demo blocked [process] Demo is blocked by ongoing work label May 30, 2023
@nadove-ucsc nadove-ucsc removed the demo blocked [process] Demo is blocked by ongoing work label Jun 12, 2023
@bvizzier-ucsc bvizzier-ucsc added the demoed [process] Successfully demonstrated to team label Jun 13, 2023
@hannes-ucsc hannes-ucsc added this to the AnVIL Public Release milestone Jun 13, 2023
@dsotirho-ucsc dsotirho-ucsc removed this from the AnVIL Public Release milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+ [priority] High bug [type] A defect preventing use of the system as specified code [subject] Production code demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

4 participants