Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings Review #4339

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Strings Review #4339

merged 3 commits into from
Dec 18, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 29, 2024

Summary

Add translation function to user-facing strings.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Check if everything is alright. No weird error or text display issue.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2880

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 3, 2024 15:32
@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 3, 2024

Plugin build for a964e9a is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 3, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel requested review from abaicus and removed request for abaicus December 3, 2024 15:36
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/translations branch 2 times, most recently from e4c42b5 to cf894cd Compare December 4, 2024 13:47
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit e4c9da9 into development Dec 18, 2024
14 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/translations branch December 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small alignment issue on the Free vs Pro tab in the Neve Options page
3 participants