Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price suffix from Neve interfering with price suffix from WooCommerce #3931

Open
AndreeaCristinaRadacina opened this issue Apr 5, 2023 · 6 comments

Comments

@AndreeaCristinaRadacina
Copy link

Hi there!

I was testing the price suffix from WooCommerce and observed that when I use that and also have prefix/suffix set in the customizer, they will all appear on the card content:
image
If the user adds a suffix from WooCommerce and a prefix from Neve, there will be typography differences.
If he adds both suffix and prefix from Neve and also suffix from Woo ( I don't know why, but maybe someone wants that ), they will all appear.

Let me know what you think!

@HardeepAsrani
Copy link
Member

Thanks @AndreeaCristinaRadacina, it seems Woo gives users a lot of options for suffix: https://elextensions.com/knowledge-base/add-suffix-woocommerce-product-prices-based-on-user-roles/

@Codeinwp/design-team My initial thought was to override one by the other but I think it might not be the best solution, given users might want to use Neve's option in addition to Woo. What do you think? Just having the same font for both should be good enough?

@mghenciu
Copy link

mghenciu commented Apr 6, 2023

I think the common font style should be enough, @HardeepAsrani.

As long as we have a separation of concerns, meaning that Neve has its own Prefix/Suffix and Woo has its own Suffix - > users ar free to use any of those, by making an informed decision what would work/look best for them. We don't force or override something.

@AndreeaCristinaRadacina
Copy link
Author

Sounds good, thank you!

@cristian-ungureanu
Copy link
Contributor

@HardeepAsrani, I don't think this is an issue. Whatever you add in WooCommerce will replace the {price} magic tag. The current solution in Neve allows you to add a template for the product price. You can add "inc. VAT" in WooCommerce, and in Neve you can have "buy for {price} for a limited time". It should work well.

@HardeepAsrani
Copy link
Member

@cristian-ungureanu Yea, it works well but the issue here is with both Woo & Neve prefix having different fonts, can we have same fonts?

@rodica-andronache
Copy link
Contributor

this is still replicable. Not all typography options are applied to the sufix from WooCommerce.

Note: to see the option for Price display suffix, you first need to enable the Tax tab, as in the screenshots

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants