Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community package requirements: sanity tests (DCNE-262) #710

Open
gotmax23 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #709
Open

Community package requirements: sanity tests (DCNE-262) #710

gotmax23 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #709
Assignees
Labels
jira-sync Sync this issue to Jira

Comments

@gotmax23
Copy link

(Note: This issue was filed in a semi-automated fashion on behalf of the Ansible Community Steering Committee. Let me know if you see errors in this issue.)

As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 2.10.1 of cisco.aci, corresponding to the v2.10.1 tag in this repo, fails one or more of the required sanity tests.

Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.

Please fix the issues identified below and then create a new Galaxy release so the fixes are caught in the next round of automated testing.

Thank you for your efforts and for being part of the Ansible package! We appreciate it.


Sanity tests

The following tests were run using ansible-test version 2.18.0:

  • ansible-doc
  • compile
  • validate-modules
  • yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.

Results

💡 NOTE:

Check the [explain] links below for more information about each test and how to fix failures.
See Sanity Tests: Ignores in the dev guide if, after reading the test-specific documentation, you still believe an error is a false positive.

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

plugins/modules/aci_cloud_subnet.py:0:0: parameter-documented-aliases-differ: Argument 'address' in argument_spec has names 'address', but its documentation has names 'address', 'subnet'
plugins/modules/aci_cloud_subnet.py:0:0: parameter-documented-aliases-differ: Argument 'name' in argument_spec has names 'name', 'subnet', but its documentation has names 'name'
plugins/modules/aci_l3out_extsubnet.py:0:0: parameter-documented-aliases-differ: Argument 'extepg' in argument_spec has names 'extepg', 'extepg_name', 'name', but its documentation has names 'extepg', 'extepg_name'
@akinross akinross added the jira-sync Sync this issue to Jira label Nov 26, 2024
@github-actions github-actions bot changed the title Community package requirements: sanity tests Community package requirements: sanity tests (DCNE-262) Nov 26, 2024
@samiib
Copy link
Collaborator

samiib commented Dec 9, 2024

@gotmax23 Thank you for raising this issue. We have recently fixed these 3 sanity issues and now run sanity tests on ansible-core 2.18.
The two issues in aci_cloud_subnet are fixed in this commit.
The other issue in aci_l3out_extsubnet was fixed in this commit.
These fixes should be released shortly in the next version of the collection.
Please let us know, if there's anything else we can help with.

@samiib samiib self-assigned this Dec 9, 2024
@samiib samiib linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-sync Sync this issue to Jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants