fail-simulator-on-error can exit with success #381
Comments
|
Yes, I've known this for a while. The Hello World example was exiting that way due to its small stack and returning from the entry point causing a trap on returning to null. Thankfully you fixed that by setting up the the thread entry point so it returns cleanly into the switcher and then thread exit. One potential solution would be to add a stackless error handler and use |
rmn30
added a commit
that referenced
this issue
Dec 18, 2024
…or handler causes a stack overflow. This uses a stackless error handler to recover from stack overflow in the stack-hungry error printing path. The handler just continues to the simulator_exit call. This is not a very satisfactory solution as it requires a call to switcher_handler_invocation_count_reset which could result in an infinite loop if an error occurs in the handler that is not handled by compartment_error_handler instead of by the stackless error handler. The stackless error handler will only be invoked if the compartment links with the unwind_error_handler library.
rmn30
added a commit
that referenced
this issue
Dec 18, 2024
…or handler causes a stack overflow. This uses a stackless error handler to recover from stack overflow in the stack-hungry error printing path. The handler just continues to the simulator_exit call. This is not a very satisfactory solution as it requires a call to switcher_handler_invocation_count_reset which could result in an infinite loop if an error occurs in the handler that is not handled by compartment_error_handler instead of by the stackless error handler. The stackless error handler will only be invoked if the compartment links with the unwind_error_handler library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the
fail-simulator-on-error.herror handler itself crashes -- by, say, exhausting the stack during aConditionalDebug::logcall -- then the simulation can end with a successful result, because we don't reach thesimulation_exit(1)call.I'm not quite sure what to do about this, but it sure is sad. It'd have been nice if HTIF and friends had allowed separately setting the exit status and commanding the exit, but alas.
The text was updated successfully, but these errors were encountered: