Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSVC schema JSON to ensure the top parent element is not part of a "definitions" as it causes issues when merging with CVE schema. #631

Closed
sei-vsarvepalli opened this issue Oct 17, 2024 · 0 comments · Fixed by #633
Labels
enhancement New feature or request
Milestone

Comments

@sei-vsarvepalli
Copy link
Contributor

Describe the bug
CVE schema would like to provide validation for the official version of the SSVC schema. This means they would like to use thier Node based tool to accept our schema. At this time, the Node tool does not offer a way to use #definitions to define the very root of the schema. Our current schema for uses such a definition - which we should update as seen in CVE JSON scheme Pull Request CVEProject/cve-schema#350

"$ref": "#/definitions/SsvcdecisionpointgroupselectionSchema"

The new schema looks like

https://github.com/CVEProject/cve-schema/blob/1c08e97929e22b1983557fe6ea5a9573831d49db/schema/imports/ssvc/ssvc-v1.0.1.json

I will submit a signed PR to resolve this.

@sei-vsarvepalli sei-vsarvepalli added the enhancement New feature or request label Oct 17, 2024
@ahouseholder ahouseholder linked a pull request Oct 24, 2024 that will close this issue
@ahouseholder ahouseholder added this to the 4Q24 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants