Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc string from "dynamic interned vars" is not shown in completion details #2552

Open
behrica opened this issue May 10, 2024 · 6 comments
Open
Labels
bug Something isn't working repl

Comments

@behrica
Copy link
Contributor

behrica commented May 10, 2024

If I define a var and its doc string dynamically:

(intern 'clojure.core
          (vary-meta
           'test123
           assoc
           :doc "doc of test")
          (fn [a b c]
            (+ a b c))
          )

and the try to complete it via

(clojure.core/test1...)

then VSCode / Calva does not render the doc string in the completion details. (only the args are shown)
while it does so for other vars in clojure.core.

Description with screenshots is here:
https://app.slack.com/client/T03RZGPFR/CBE668G4R

@behrica
Copy link
Contributor Author

behrica commented May 10, 2024

It does work for "hover" over the var, there the doc string is shown, only missing while completing.

@behrica
Copy link
Contributor Author

behrica commented May 10, 2024

we would like to have this working due to tghis work ongoing:
scicloj/clojisr#98

This would render the "help" of "R functions" expressed as Clojure vars.
It does work in Emacs.

@PEZ
Copy link
Collaborator

PEZ commented May 10, 2024

Yeah, it's intended to work.

@behrica
Copy link
Contributor Author

behrica commented May 10, 2024

One different between "hover logic" and "completion logic" is this:

if (util.getConnectedState())

vs

if (util.getConnectedState() && item['data']?.provider === 'repl') {

@behrica
Copy link
Contributor Author

behrica commented Sep 21, 2024

any new on this ?

@PEZ
Copy link
Collaborator

PEZ commented Sep 21, 2024

Hello. I had completely forgotten about this. I'm sorry!

Now checked and from what I can see we do have the docs in the results from nrepl, but we somehow bork it in our InfoParser. Here's the call:

https://github.com/BetterThanTomorrow/calva/blob/published/src/providers/completion.ts#L111

I don't think it should be too hard to fix. Do you want to have a go at it? Otherwise I will get to it some day soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repl
Projects
None yet
Development

No branches or pull requests

2 participants