subscription-ci Pipeline no changes detected

[theMK2000]

I am not sure if anyone can assist with this but when I run the subscriptions-ci pipeline in azure ado it succeeds but it is saying under the trigger subscription deployment

No subscription configuration changes detected in current commit ()

So none of the code changes appear in the subscription I have spent time trying to resolve this issue. Can anyone advise me on troubleshooting this? Let me know if you need any more information. I am sure this is a simple error on my side.

[skeeler]

@theMK2000 the subscriptions pipeline can be triggered or run manually.

When triggered (not the default state in the subscriptions.yml pipeline definition) it will examine the files in the triggering commit and run the pipeline (as parallel jobs) on any included subscription configuration files (newly added) under the /config/subscriptions path.

When run manually, there are two parameters requested, one of which must be supplied:

• The commit id parameter allows you to provide a previous git commit hash value, and the pipeline logic from that point is similar to the flow mentioned in the triggered case.
• The subscription ids (a comma-separated array) parameter value is the most often used option when running the pipeline manually. In this case, you need to provide the subscription GUID(s) - or enough of the prefix of each so it/they can be uniquely found under the /config/subscriptions folder in the Git repo. The pipeline will perform a recursive prefix matching search for each value to locate its corresponding configuration file.

If you're already doing this, then the next thing to check is ensuring that your subscription configuration files are located under the correct folder path.

For example, let's say I have a config file for the following subscription:

• My Azure DevOps organization name is: MyAzDevOpsOrg
• The branch I am running pipeline & accessing repo code from is: main
• The subscription GUID is 4f9f8765-911a-4a6d-af60-4bc0473268c0 and that uniquely identifies it across my subscriptions
• I want to use the lz-generic-subscription landing zone template (archetype)
• I want to place it in the canadaeast region
• I want to move it under a management group with the identity LandingZonesProduction

With the above requirements, I would need to create a subscription configuration file with the following name & location:

/config/subscriptions/MyAzDevOpsOrg-main/LandingZonesProduction/4f9f8765-911a-4a6d-af60-4bc0473268c0_generic-subscription_canadaeast.json

When I run the subscriptions-ci pipeline (on the main branch), I can enter 4f9f as the subscription id - assuming there are no other subscriptions that start with the same 4 hex digits under the /config/subscriptions/MyAzDevOpsOrg-main folder hierarchy.

[theMK2000]

Thank you now I am getting another error.

`Invoke-RestMethod: /home/vsts/work/temp/01b210fa-a496-4239-a44c-3a4f91a414f6.ps1:16
Line |
16 | … $pipeline = Invoke-RestMethod -Uri $url -Headers $headers -Method Pos …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| {"$id":"1","innerException":null,"message":"Stage
| DeploySubscriptionsStage job
| DeploySubscriptionJob_BCFinancialServicesAuthority_main/bcfsasandbox/618eb669_d7d2_4148_bee9_d93f9e932cd2_generic_subscription_canadacentral.json has an invalid name. Valid names may only contain alphanumeric characters and '' and may not start with a number.","typeName":"Microsoft.Azure.Pipelines.WebApi.PipelineValidationException, Microsoft.Azure.Pipelines.WebApi","typeKey":"PipelineValidationException","errorCode":0,"eventId":3000}

`

I believe this has something to do with trigger-subscriotions.yml I will try and trouble shoot this tomorrow thank you for helping

[skeeler]

@theMK2000 sorry it's taken a while to respond. From the error message above, it appears your subscription configuration file name and the archetype/template name are both using the underscore ("_") character, but should be using the dash ("-") character instead. E.g. 618eb669-d7d2-4148-bee9-d93f9e932cd2_generic-subscription_canadacentral.json. The underscore is only used to separate the subscription GUID from the archetype/template from the region/datacenter.

[theMK2000]

@skeeler Thanks for responding I used the bellow on my file name but still get the error.

As you can see 1) the value is correct I believe but then once the file name is parsed at 2) it is all _ though the issue seems to be that it starts with a # I am not 100% sure that is the issue and not sure how to get around it do I add _ at the start?

[skeeler]

@theMK2000, I will try to reproduce today in my environment to see if it's an issue with the pipeline logic or perhaps something environmental. While I'm working on this, I'd appreciate if you could share the approximate date your code was cloned/forked from the main repository, and whether you have made any changes to the pipeline logic.

[theMK2000]

We cloned it about 3-4 months ago. We did not make any changes to the pipeline logic.

[skeeler]

hi @theMK2000, I examined several places to ensure the pipeline task script logic was valid (it was). In the end, it turns out that the Invoke-RestMethod call is failing due to the presence of the / characters in the fully qualified path name of each Added or Modified subscription configuration (JSON) file. This code hasn't changed since before 2021-09-30 and was working then, so I can only assume that something in the PowerShell module containing the Invoke-RestMethod cmdlet has changed in the interim.

To fix the error you are encountering, you'll need to make the following changes to the .pipelines/templates/jobs/trigger-subscriptions.yml file and commit to your Azure DevOps repository. Following are both a visual and textual representation of the changes needed:.

First, the visual representation. The code additions are marked in green on the right hand side, and the code changes are marked in red/green with green representing final state:

For the textual representation, you will copy/paste the following block of code directly following line 91 in the current code:

$paths = $env:SUBSCRIPTION_CHANGES -split ','
$guids = $paths -replace '.*?([0-9a-f]{8}[-]?([0-9a-f]{4}[-]?){3}[0-9a-f]{12}).*', '$1'
$changes = $guids -join ','

After pasting the above code block after existing line 91, you will change the $env:SUBSCRIPTION_CHANGES variable reference (on what is now line 98) to be: $changes.

I tested these changes by performing the following actions:

1. Set the var-TriggerSubscriptionDeployOn variable to AM (in common.yml)
2. Enabling CI trigger in the subscriptions.yml pipeline definition file
3. Adding a new subscription configuration file and monitoring its 2 resultant pipeline runs through successful completion
4. Modifying an existing subscription configuration file and monitoring its 2 resultant pipeline runs through successful completion

The results of the 2 pipeline CI triggers (each spawning a manual pipeline run) are shown below:

These pipeline runs are displayed in reverse order of execution.

[skeeler]

@theMK2000 did you push the committed changes back to your Azure DevOps repo? From the same error message shown, it looks like the pipeline is still using original code version.

[theMK2000]

Yes, I double-checked the code in ADO and it is updated and committed to the main branch. You can see by the error above it is parsing the file path differently from before but there is still a higher folder structure that is passed with the /. Though it seems to be passing the entire path.

subscriptions.yml

trigger-subscriptions.yml

[skeeler]

@theMK2000, you're missing a couple of "*" characters in the replace string for variable $guids. It should look like this (from my test environment):

Here is the code from earlier post above:

$guids = $paths -replace '.*?([0-9a-f]{8}[-]?([0-9a-f]{4}[-]?){3}[0-9a-f]{12}).*', '$1'

Try adding the missing asterisks and rerun.

[theMK2000]

@skeeler God thank you I copied and pasted not sure how that happened but it is now running! Thanks for your assistance with this.

[skeeler]

Great news and happy to help.