Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: provide a non-recursive flag #101

Open
ghuser opened this issue Mar 5, 2020 · 1 comment
Open

Feature request: provide a non-recursive flag #101

ghuser opened this issue Mar 5, 2020 · 1 comment

Comments

@ghuser
Copy link

ghuser commented Mar 5, 2020

It would be a nice feature to provide a non-recursive watch flag.

Recursive watch can cause inotify watch exhaustion on linux.

non-recursive flag would give the ability to library users to watch with exclusions (e.g. node_modules), by first calculating themselves all directory paths that should be watched and then registering that many watchers on nsfw.

vscode currently faces an issue with this. They register each of the root directory paths in the workspace, and then just filter-out event delivery in case the path is in the exclusion list. But the inotify watches are already registered. see related code

I think providing this feature might solve this issue and many duplicates of it (with low effort on vscode side) without the need to switch to a different watcher library.

@ghuser
Copy link
Author

ghuser commented Jul 19, 2021

Any news on this feature request?

Guidelines related to technical difficulties/pitfalls that development of this feature might involve
could be helpful to community for creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant