-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show # of Covered Lines Diff in Summary #359
Comments
Hey @grant 👋, Great idea! I think that report could just contain statement/branch/etc. delta, if percent change is insignificant. For instance, in your case, this could look like:
So if percent delta is below some threshold (for instance I think, with this format, the report will contain more useful information in large codebases, while being simple in smaller repositories. Let me know what you think about this solution! |
Yeah that resulting UI would be perfect @ArtiomTr! I think the 0.1 threshold sounds reasonable, users don't get much info from that percentage change, but may get some useful info from the line change at that level. Not sure how hard it is to change that; happy to test it. |
@grant PRs are welcome, if you have any questions regarding the code - feel free to ping me 🙌 |
I'll try to get to a PR for this, thanks! |
Note: I'm not able to get to a PR for this, tried but it was a little complicated setting things up. We're using a different reporting method, but could use this action in the future. |
Idea
Our codebase always shows coverage diff results that aren't significant. Examples:
I'd like to report the exact number of statements/branches/functions/lines covered and added/removed. For small PRs it will show something like 0 of 4 statements added have coverage.
Description
Here's a proposal.
Actual
Desired
Alternatives
Not show the diff number, only show the diff percent.
Additional context
Happy to create a PR, or just start a discussion.
jest-coverage-report-action/src/format/summary/formatCoverageSummary.ts
Line 29 in 952a059
The text was updated successfully, but these errors were encountered: