This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
[#152] Fix cURL/XML import missing '=' #155
Open
+73
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffhll
commented
Feb 29, 2024
| @@ -147,7 +147,6 @@ export async function scanResources({ | |||
|
|
|||
| export const importPure = async (json: { resources: BaseModel[] } & any) => { | |||
| const _resources = json.resources; | |||
| // console.log("importPure", json); | |||
There was a problem hiding this comment.
debug line so so lets just remove it.
|
@archywillhe bump on this PR. Any chance we can get it reviewed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
Added a special case for xml in the curl parser along with a test and some small cosmetic cleanups.
Additionally, there seems to be some lint fixes that CI caught. Fixing those using the recommended change as per the logs. Whitespace changes are auto-changes by VSCode to improve readability.