data.js redundant properties

[f0nar]

Hi!
I created custom extension that includes functions with inline code and custom object (object uses functions). I dont want to share it here as it is super specific testing example for custom needs and I am sure that it will confuse you even more. I think extension structure is the key

Then I exported my game as HTML5 game export and found an interesting thing
All of my inline code which is more then 2.4k lines was wrapped and placed in gdjs-evtsext__...smth...-func.js file which is OK. But then I realized that it is duplicated in data.js file in projectData.eventsFunctionsExtensions.eventsFunctions property. I checked GDevelop repo and found that eventsFunctionsExtensions property is typed as EventsFunctionsExtensionData[] where

declare interface EventsFunctionsExtensionData {
  name: string;
  eventsBasedObjects: EventsBasedObjectData[];
}

declare interface EventsBasedObjectData {
  name: string;
  objects: Array<ObjectData & any>;
}

so this duplicated code is not used in runtime in any way as I understand. So why is it there as well as a lot of other properties which are not specified in EventsFunctionsExtensionData type?

In addition I see that there is no such duplications for my other extension that define functions with inline code (but not custom object). Is this due to usage in custom object?

[D8H]

Thank you for reporting this issue, it will be solved by this PR:

• Unify variable instructions and handle local variables #6459

[f0nar]

sounds great. will it solve issue with all properties that are unused in runtime?

[D8H]

It removes eventFunctions content.

[f0nar]

what about other properties like author, category and so on? are they really needed in runtime?

[4ian]

Probably a good idea to have a method StripForExport for these data.
StripProjectForExport can call them on each extension and other classes (I'm not talking about a generic solution, just a bunch of loops and method calls).

cc @D8H let's do this?

[f0nar]

that sounds great