Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP notice for requests in the admin #113

Open
barryceelen opened this issue Oct 18, 2018 · 0 comments
Open

PHP notice for requests in the admin #113

barryceelen opened this issue Oct 18, 2018 · 0 comments

Comments

@barryceelen
Copy link
Member

This line is creating a php notice for me when doing unrelated requests in the admin:

Notice: Undefined index: account in myawesomefilepath/plugins/brightcove-video-connect-1.3/includes/admin/class-bc-admin-settings-page.php on line 20

The delete_source() function is called on every admin request via add_action( 'admin_init', array( $this, 'delete_source' ) );. It may be more suitable to add a specific action to this GET request, point it at admin-post.php and have add_action( 'admin_post_mycoolaction handle it.

@jeffpaul jeffpaul added this to the Future Release milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants